[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-patch-tracker] [patch #7929] Partial Differential Equation Solve
From: |
Mark Wistrom |
Subject: |
[Octave-patch-tracker] [patch #7929] Partial Differential Equation Solver in two dimensions |
Date: |
Tue, 12 Feb 2013 03:35:01 +0000 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1) AppleWebKit/537.17 (KHTML, like Gecko) Chrome/24.0.1312.57 Safari/537.17 |
Follow-up Comment #10, patch #7929 (project octave):
The '1' at the top of the files is due to incompetence. The '1's have all been
removed.
My call is core function, but I won't argue hard for that. Matlab has this as
a core function. It seems to me that pdepe is a "nice to have" or "handy"
function. I get the impression that it will be used for education,
prototyping or "single shot" calculations. Not something that would be used in
a heavily used or "industrial" scenario, if that makes any sense. Ease of
discovery and ease of use seem to be important. But I don't know how you are
positioning Octave.
I think it will probably used mostly for education. See example 5: "Cooking
the Turkey." http://cbe255.che.wisc.edu/diffusion.pdf
I've read the style issues you pointed me to and made the following changes:
1. change 'inline' to @
2. change all "ends" to "endif", etc
3. change comments to all "%"
4. add space between function and argument to distinguish functions from
indexing
5. use single single quoted strings
6. pare lines to under 80 char (except for the function definition in the
'help'. I think I got it right.)
7. use !=
8. use spaces, no tabs
9. use Unix newlines
10. put spaces after ','
11. use lower case names for functions and variables
12. enclose "if" and "switch" test conditions with ()
I have removed much of the duplicate code. There was more than I remembered.
:)
So the trivial loops are in the examples, which I do know what to do with. I
have not changed the examples to use more efficient coding, because I don't
know where those examples should go. I can change them, if needed. Do they get
used as tests? Do I provide tests with the code? Also, the examples return a
single value for the 'c,f,s' parameters, not vectors, just like Matlab's
functionality. This seems to have a pretty big performance hit, which I
discussed below.
I'll post the functions and examples soon.
Thanks,
Mark
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/patch/?7929>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
- [Octave-patch-tracker] [patch #7929] Partial Differential Equation Solver in two dimensions, Jordi Gutiérrez Hermoso, 2013/02/06
- [Octave-patch-tracker] [patch #7929] Partial Differential Equation Solver in two dimensions, Jordi Gutiérrez Hermoso, 2013/02/06
- [Octave-patch-tracker] [patch #7929] Partial Differential Equation Solver in two dimensions, Jordi Gutiérrez Hermoso, 2013/02/06
- [Octave-patch-tracker] [patch #7929] Partial Differential Equation Solver in two dimensions, Mark Wistrom, 2013/02/06
- [Octave-patch-tracker] [patch #7929] Partial Differential Equation Solver in two dimensions,
Mark Wistrom <=
- [Octave-patch-tracker] [patch #7929] Partial Differential Equation Solver in two dimensions, Mark Wistrom, 2013/02/12
- [Octave-patch-tracker] [patch #7929] Partial Differential Equation Solver in two dimensions, Dongxu, 2013/02/14
- [Octave-patch-tracker] [patch #7929] Partial Differential Equation Solver in two dimensions, Mark Wistrom, 2013/02/14
- [Octave-patch-tracker] [patch #7929] Partial Differential Equation Solver in two dimensions, Mark Wistrom, 2013/02/14