[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-patch-tracker] [patch #7970] Added trivial OpenMP constructs to
|
From: |
John W. Eaton |
|
Subject: |
[Octave-patch-tracker] [patch #7970] Added trivial OpenMP constructs to liboctave/array classes as an experiment. |
|
Date: |
Sun, 10 Mar 2013 22:30:53 +0000 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.11) Gecko/20100101 Firefox/10.0.11 Iceweasel/10.0.11 |
Follow-up Comment #1, patch #7970 (project octave):
Your patch does more than add #pragmas. For example, I see changes like the
following:
@@ -2021,15 +2027,13 @@
{
Complex tmp = work[k] / data (cidx (k+1)-1);
work[k] = tmp;
- for (octave_idx_type i = cidx (k);
- i < cidx (k+1)-1; i++)
- {
- octave_idx_type iidx = ridx (i);
- work[iidx] = work[iidx] - tmp * data (i);
- }
+ #pragma omp parallel for
+ for (octave_idx_type i = cidx (k); i < cidx
(k+1)-1; i++)
+ work[ridx (i)] -= tmp * data (i);
}
Could you please undo these kinds of changes and make the patch add #pragmas
only? That will be much easier to evaluate.
I'm not opposed to the other kinds of changes, but let's make them
separately.
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/patch/?7970>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/