[Octave-patch-tracker] [patch #7994] ind2rgb - Enabling handling of ND images

[Jordi Gutiérrez Hermoso]

Update of patch #7994 (project octave):

                  Status:                    None => In Progress            
             Assigned to:                    None => jordigh                

    _______________________________________________________

Follow-up Comment #1:

he patch looks good. I am only bothered by minor stylistic issues.

    1) It needs a commit message:

          http://wiki.octave.org/Commit_message_guidelines

       Look at "hg log -v" to look at other examples of commit
       messages.

    2) The traditional variable name is "sz = size (x)", not "xdim".

    3) Instead of

           R = vertcat (R(:), G(:), B(:));
           R = reshape (R, horzcat (xdim, 3));

      I would write

           R = reshape ([R(:); G(:); B(:)], [sz, 3]);

      or even, to be visually suggestive,

           R = reshape ([R(:)
                         G(:)
                         B(:)], [sz, 3]);

      I just find that using [a; b] or [a, b] is easier to read than
      horzcat or vertcat. If you think my version is less readable,
      keep yours.

If you're currently standing on your patch (hg up -r 486ebe96d), you
may want to use, after making your changes, the following:

    hg commit --amend

to amend your current patch.

Looking forward to your contribution,

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?7994>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/