[Octave-patch-tracker] [patch #8010] Change workspace row height to 20 pixels.

[Dan Sebald]

Follow-up Comment #5, patch #8010 (project octave):

Using resizeRowToContents() is about 20% less height than pre-changeset, but
it still has pretty much whitespace.  (One would think that
resizeRowToContents() is what is being used by default.  I guess not.)

If that amount of whitespace is alright with others, it's fine by me.  But a
little less would be nice.  [I also think that a little too much space is
taken up by the editor menu items and icons.  Maybe that isn't the case for a
monitor bigger than I have or of higher resolution.]

The spacing within resizeRowToContents can be changed via the delegate size
hint:

http://qt-project.org/doc/qt-4.8/qtableview.html#sizeHintForRow

But that would require creating a class that inherits the QTableView.  Not a
difficult thing to do.  Probably the proper thing to do.  But ultimately the
row height scaling is tied to font height somehow.

Should we look a little further at what the code (link below) is doing?

http://qt.gitorious.org/qt/qt-gberg/blobs/90cdbf8bd409652fd1e28adcd7f02fc1fae2c1c0/src/gui/itemviews/qtableview.cpp#line1474

It looks to me that every column in the row is checked for the height it
requires and then I assume the row is chosen as the maximum.  To get the
required size, the QItemDelegate is inquired for the given index.  I'm
guessing that an item delegate is something that specifies the height of an
object without having to render that object.

So, maybe we'd have to go back to the items within the table and change their
delegate somehow.


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8010>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/