octave-patch-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-patch-tracker] [patch #7999] Further adjustments to fftfilt afte


From: Dan Sebald
Subject: [Octave-patch-tracker] [patch #7999] Further adjustments to fftfilt after changeset for bug 37297
Date: Fri, 26 Jul 2013 06:10:59 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:18.0) Gecko/20100101 Firefox/18.0 SeaMonkey/2.15

Follow-up Comment #4, patch #7999 (project octave):

Yes, that comment is good.  Typically capital N is used when referring to
FFTs, but it's not critical.  That accounts for one of the issues.  Thanks.

The bulk of this patch concerned properly using the fftfilt() approach.  If
I'm recalling correctly, someone had complained about the fftfilt being slow. 
However, my conclusion was that there is a proper circumstance for choosing to
use fftfilt compared to normal convolution.  Do we want to address that in
some way?  E.g., make note in the documentation, or include the warning
message that is part of the patch?  If not, let's close the entry.

I still need to tweak one of the tests, but that can be a separate bug/patch
report.


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?7999>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]