[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-patch-tracker] [patch #8320] [mapping package] Conversion betwee

From: Carnë Draug
Subject: [Octave-patch-tracker] [patch #8320] [mapping package] Conversion between units of length
Date: Sat, 22 Feb 2014 19:53:53 +0000
User-agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20140207 Firefox/24.0 Iceweasel/24.3.0

Follow-up Comment #1, patch #8320 (project octave):

At a first glance, I don't see anything wrong with the patch.

I believe you are an applicant to GSoC trying to get acquainted with Octave by
taking items from the Short projects page, so I'd suggest you could prepare
two more csets on top of this one.

One to change the NEWS and INDEX file to make reference of the new functions.
See for example, csets 92dd0071c58d and f7c6d8890730, that also add new
functions to this files.

On other to add a few extra tests to convert values in a vector and ND matrix.
Something like:

%! km = [1.8520    3.7040    5.5560    7.4080    9.2600   11.1120];
%! nm = [1 2 3 4 5 6];
%! assert (km2nm (km), nm)
%! km = reshape (km, [1 3 2])
%! nm = reshape (nm, [1 3 2])
%! assert (km2nm (km), nm)

Of course, any more tests you can think of are welcome.


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]