[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-patch-tracker] [patch #8534] For GUI undo, send Cntrl-U to Readl

From: Dan Sebald
Subject: [Octave-patch-tracker] [patch #8534] For GUI undo, send Cntrl-U to Readline rather than callback command_editor.
Date: Sat, 13 Sep 2014 17:42:52 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:18.0) Gecko/20100101 Firefox/18.0 SeaMonkey/2.15


                 Summary: For GUI undo, send Cntrl-U to Readline rather than
callback command_editor.
                 Project: GNU Octave
            Submitted by: sebald
            Submitted on: Sat 13 Sep 2014 05:42:51 PM GMT
                Category: None
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any



Here is a changeset to change the manner in which Undo is implemented in the
GUI.  Similar to the following patch which removes the need to access the core


the attached patch will do the same by placing the undo operation for the
terminal not at the main_window level, but at the TerminalView level.

This is a more object-oriented form of design in which the implementation of
undo, specific to the object, is part of the object.  That is, "Undo" can be
interpretted in different ways by different widgets.  For the terminal it
means one thing, for the editor something different, and for new features it
might mean something different.

What is done at the main_window level is to associate the Undo operation with
whatever widget becomes in focus.  This is the more conventional behavior of
GUI design these days, I think.  To reflect this, the Undo action will
enable/disable the icon and Cntrl-Z based upon whether the tab widget has an
Undo implementaton (i.e., slot).


File Attachments:

Date: Sat 13 Sep 2014 05:42:51 PM GMT  Name:
octave-gui_undo_action-2014sep13.patch  Size: 6kB   By: sebald



Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]