[Octave-patch-tracker] [patch #8534] For GUI undo, send Cntrl-U to Readline rather than callback command_editor.

[Dan Sebald]

URL:
  <http://savannah.gnu.org/patch/?8534>

                 Summary: For GUI undo, send Cntrl-U to Readline rather than
callback command_editor.
                 Project: GNU Octave
            Submitted by: sebald
            Submitted on: Sat 13 Sep 2014 05:42:51 PM GMT
                Category: None
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

Here is a changeset to change the manner in which Undo is implemented in the
GUI.  Similar to the following patch which removes the need to access the core
command_editor:

https://savannah.gnu.org/patch/index.php?8532

the attached patch will do the same by placing the undo operation for the
terminal not at the main_window level, but at the TerminalView level.

This is a more object-oriented form of design in which the implementation of
undo, specific to the object, is part of the object.  That is, "Undo" can be
interpretted in different ways by different widgets.  For the terminal it
means one thing, for the editor something different, and for new features it
might mean something different.

What is done at the main_window level is to associate the Undo operation with
whatever widget becomes in focus.  This is the more conventional behavior of
GUI design these days, I think.  To reflect this, the Undo action will
enable/disable the icon and Cntrl-Z based upon whether the tab widget has an
Undo implementaton (i.e., slot).




    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Sat 13 Sep 2014 05:42:51 PM GMT  Name:
octave-gui_undo_action-2014sep13.patch  Size: 6kB   By: sebald

<http://savannah.gnu.org/patch/download.php?file_id=32088>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8534>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/