[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-patch-tracker] [patch #8534] For GUI undo, send Cntrl-U to Readl

From: Dan Sebald
Subject: [Octave-patch-tracker] [patch #8534] For GUI undo, send Cntrl-U to Readline rather than callback command_editor.
Date: Thu, 18 Sep 2014 22:57:26 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:18.0) Gecko/20100101 Firefox/18.0 SeaMonkey/2.15

Follow-up Comment #3, patch #8534 (project octave):

I thought about the re-assigning of key bindings, but I don't know what to do
there other than leave it that way.  The octave code is calling:

octave_rl_do_undo (void)
  return rl_do_undo ();

and I think that rl_do_undo () is a library function.  So, conceptually there
is an "undo" in readline, and most of the documentation out there points to

What about Cntrol-z?  Can that be reassigned (or even used) for the terminal? 
C-z seems to be grouped with C-c as a stty signal--what the implies about
bindings, I don't know.  Nonetheless, C-z can't be sent to the terminal (could
be programmed to allow it, but currently doesn't).

I just realized the current implementation has two "undo"s.  That is, the
"Cntrl-z" shortcut and the green undo arrow behave differently.  Type this:

I went to sea<backspace>e the sea.

Now type Cntrl-z a few times and watch what happens.  (Basically "untypes".) 
Then type the same thing again and then press the green arrow.  (The whole
line disappears...like default Cntrl-u in Readline.)

Hmm, there seems to be a perhaps non-minor conflict here, and maybe some
options are needed.  Right now, Qt shortcuts aren't working in the terminal
window.  Is that good or bad?  Depends on viewpoint.  For example, Cntl-o Qt
shortcut is to open a file.  But it only works when focus is outside of the
terminal window (click in the workspace window, then type Cntrl-o).  Wouldn't
a user expect that when typing at the command line that Cntrl-o would put up
the "open" dialog box?

I way around this would be to have an option

[x] Command line uses Readline bindings
[ ] Command line uses Qt bindings

and then have as a shortcut to changing that option something in the right
mouse click popup window.  Also, there could probably be an "Undo" in the
right click popup window.


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]