[Octave-patch-tracker] [patch #8535] [signal] firpm (new remez)

[Mike Miller]

Follow-up Comment #7, patch #8535 (project octave):

Thanks Laurent for evaluating this patch and providing feedback. I still
haven't had the time to look at this in much depth yet.

At a glance, though, I would like it if C++ submissions to the signal package
conform to the Octave and GNU coding standards. It looks to me like you want
to use this code elsewhere, and have a script to combine it into one file for
compilation as a .oct file. That's fine, but code distributed with the signal
package should be consistent with the coding style of Octave. If it isn't
submitted that way, it will be reformatted later eventually, and won't be
comparable to your original source.

It would also be preferable to use standard library and Octave library
functions where possible, e.g. use std::max() and xround() instead of defining
your own :)

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8535>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/