[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-patch-tracker] [patch #8612] impyramid.m for image package
From: |
Carnë Draug |
Subject: |
[Octave-patch-tracker] [patch #8612] impyramid.m for image package |
Date: |
Sat, 30 May 2015 15:41:25 +0000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Firefox/31.0 Iceweasel/31.7.0 |
Follow-up Comment #4, patch #8612 (project octave):
This is not really handling 3 dimensional images. In such cases, it is only
reducing and expanding the 1st and 2nd dimension, and leaves the 3rd dimension
intact. I understand that fixing imfilter to handle those cases correctly but
as it is, it cannot be accepted. It will cause a lot of problems on the long
run.
Let us suppose that I accept and release this as part of the image package.
Users will start to expect it to behave like this. Then one day we finally fix
it so it handles extra dimensions correcly. All the users will need to go and
change their code. That can't be. It will be better if you just limit to 2
dimensions if you can't fix imfilter.
However, if you do it, please do it in such way that this limitation can be
easily remove as soon as imfilter is able to handle more dimensions, like so:
case "reduce"
for d = 1:nd
im = imfilter (im, vec (filt, d), "replicate");
endfor
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/patch/?8612>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Octave-patch-tracker] [patch #8612] impyramid.m for image package,
Carnë Draug <=