[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-patch-tracker] [patch #8713] image package: new color conversion
[Octave-patch-tracker] [patch #8713] image package: new color conversion functions: rgb2lab etc.
Mon, 12 Oct 2015 18:50:00 +0000
Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:41.0) Gecko/20100101 Firefox/41.0
Follow-up Comment #2, patch #8713 (project octave):
I have written and tested this bundle of functions with Octave 4.0.0 (release
version), and the dev version of the image package (directly from the hg
repository, at the time of the patch creation, several weeks ago now.) And, as
you probably expected, I have NOT seen any test fail.
I suspect that maybe the two versions of colorspace_conversion_input_check.m
became mixed up. You, Carne, submitted ONE version into Octave core some month
ago. And I have submitted ANOTHER slightly changed version of the very same
function into the "private" subdirectory of the image package. And the "Carne
version" will make some tests of my new functions fail!
So if you are using the dev version of Octave as well as the dev version of
the image package, then Octave might mix up which of those two version of
colorspace_conversion_input_check.m it should use.
Or do I need to "publish" the private function inside the image package
somewhere? I think this narrows down to the question: How can we make sure
that the function from the image PACKAGE subfolder "inst/private/" and not the
function from the Octave CORE folder "scripts/image/private" is used by my new
functions? Or should I better rename my new versions of those two private
helper functions in order to make this work?
Reply to this item at:
Nachricht gesendet von/durch Savannah