[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-patch-tracker] [patch #8709] fixes to color conversion functions

From: Carnë Draug
Subject: [Octave-patch-tracker] [patch #8709] fixes to color conversion functions (mainly rgb2ntsc and ntsc2rgb)
Date: Wed, 28 Oct 2015 22:42:16 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Firefox/38.0 Iceweasel/38.3.0

Follow-up Comment #8, patch #8709 (project octave):

Since you also agree, I have then pushed those changes with a bunch more
tests.  I have also added support for signed integer images (image package
supports int16 but this adds support for int16 and int8).  See


One thing that I noticed while writing the tests is that the conversion from
integers to double by ntsc2rgb does not really work.  The reason is that we
are currently scaling the values into the [0 1] range. However, ntsc values
are not meant to be on that range (do not believe Matlab documentation, it's
all wrong).  Just consider the values from its sister function rgb2ntsc

octave> rgb2ntsc ([0 1 0])
ans =

   0.58700  -0.27400  -0.52300

How should we be scaling integer values for NTSC?


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]