octave-patch-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-patch-tracker] [patch #8951] Calculate vertexnormals for patch o


From: Markus Mützel
Subject: [Octave-patch-tracker] [patch #8951] Calculate vertexnormals for patch objects
Date: Wed, 8 Jun 2016 17:16:26 +0000 (UTC)
User-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:47.0) Gecko/20100101 Firefox/47.0

Follow-up Comment #21, patch #8951 (project octave):

With the attached patch, a new light object triggers the axes object to call
update_normals for all patch (and maybe in the future also surface) objects.

I think I now understand why "numlights" never decreased with your patch: In
"delete_graphics_object", gh_manager::free (h) is called before the call to
remove_child. Thus, the gh_manager could not find the light object by its
handle.

Anyway, since it is quite complicated to keep track of which lights are
directly within the axes or in (nested) hggroups and which of them are
invisible or in invisible (nested) hggroups, I kept with the original approach
of detecting one visible light that descends from the axes ancestor of the
patch object.

I removed all of the debugging code and re-organized the BISTs so that the
patch should be clean now.

If the current patch is more or less what we want, I will start to update the
documentation.

(file #37433)
    _______________________________________________________

Additional Item Attachment:

File name: patch_normals_v6.patch         Size:21 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8951>

_______________________________________________
  Nachricht gesendet von/durch Savannah
  http://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]