[Octave-patch-tracker] [patch #8713] image package: new color conversion functions: rgb2lab etc.

[Carnë Draug]

Update of patch #8713 (project octave):

                  Status:                    None => Done                   
             Open/Closed:                    Open => Closed                 

    _______________________________________________________

Follow-up Comment #9:

Yes. I'm sorry for the high delay. Thank you for the patch.

There are a couple of nitpicks things I would prefer though which you may want
to address:

1) I would prefer to use a whitepoint function (missing function) instead of
hard coded whitepoint values (this would also allow to implement the
illuminant option in this functions)

2) I'm not super familiar with this topic so I can't evaluate the differences
you made on purpose from Matlab.

3) I would prefer that the tests compared the results with computed values
instead of 3 decimal numbers. So that future changes that heavily change the
precision of results.

4) Avoiding many temporary variables would increase performance. For example,
when converting rgb 2 lab, there is a time where Octave has the image in rgb,
xyz, and lab colorspace in memory at the same time.

5) In the conversions where matrix multiplication is not used, the logic in
colorspace_conversion_input_check can be simplified and a permute removed.
That further reduces computation (see
http://hg.code.sf.net/p/octave/image/file/dde7ec8122b9/inst/private/lab2cls.m#l24
for an example).

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8713>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/