[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-patch-tracker] [patch #9014] Add "camlight" function
From: |
Colin Macdonald |
Subject: |
[Octave-patch-tracker] [patch #9014] Add "camlight" function |
Date: |
Mon, 11 Jul 2016 06:13:10 +0000 (UTC) |
User-agent: |
Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:47.0) Gecko/20100101 Firefox/47.0 |
Follow-up Comment #9, patch #9014 (project octave):
I looked at this again.
* I think I've fixed Markus's comments (I worked on top of the v2 patch).
* I made a new __rotate_around_axis__ helper function (its split out from
scripts/util/rotate/m; I also need this in some upcoming cam* functions).
* I wrote __plt_get_light_arg__ to detect light handles and trim varargin.
This is a private function in camlight.m for now (but could easily be split
out if useful elsewhere).
* Input handling is simpler, although I a special-case to deal with
double-is-coincidently-a-handle problem discussed below.
* I include an optional separate patch to make "scripts/util/rotate.m" use the
new private __rotate_around_axis__ helper. This avoids duplicated code. The
performance penalty is extra function calls, plus some redundent scalar
computations of sind/cosd (which are now done inside a loop), neither of which
seems like a big deal to me. But anyway, its not required for camlight.
(file #37796, file #37797)
_______________________________________________________
Additional Item Attachment:
File name: camlight_v3.patch Size:12 KB
File name: rotate_use_splitoff_v1.patch Size:1 KB
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/patch/?9014>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/