octave-patch-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-patch-tracker] [patch #9056] documentation for Java methods and


From: Ernst Reissner
Subject: [Octave-patch-tracker] [patch #9056] documentation for Java methods and fieldnames
Date: Tue, 26 Jul 2016 10:21:19 +0000 (UTC)
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:47.0) Gecko/20100101 Firefox/47.0

Follow-up Comment #3, patch #9056 (project octave):

Hi Mike, 
Well done, but I have still some comments on the comments of fieldnames: 
- You missed the description if a struct is given. 
- I missed the information that for java 
  only the member fields are returned. 
The latter may be a bug. 
Is there someone with a new version of matlab to try? 
Maybe just have a look at 'help fieldnames'.
Try: 
octave:1> fieldnames('org.octave.ClassHelper')
ans = {}(0x0)
although scripts/java/org/octave/ClassHelper.java 
clearly shows a static field (loader). 

Whether bug or not, the behavior shall be documented. 

With your version of methods.m i am not content. 
If you hava a look at the code, 
there are three cases which shall be clearly commented: 
- octave-object
- octave-classname 
- java-object 
- java-classname. 

This was done with my comments but not with yours. 
Also part of my rewording comes from my intent to unify the two comments. 

For methods.m I made the mistake to say that the NAMES of the public methods
are returned, 
In fact it is the SIGNATURE without access modifier. 

I also forgot to comment, that for java only the MEMBER methods are returned.

As for fieldnames, I suppose it is a bug or a deficiency 
not to display the static methods. 


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?9056>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]