[Octave-patch-tracker] [patch #8960] Preliminary balancing and balance option for eig

[Barbara Lócsi]

Follow-up Comment #9, patch #8960 (project octave):

The problem with F77 macros[1] were because these were recently introduced and
I haven't pushed it to my repository (the patch I uploaded contained it) . The
push is now done so now my repository is also up to date. 

I edited eig.cc to match the coding guidelines as you noted (and deleted the
unnecessary trues form the asserts)  and also pushed it to my repository.

The test you wrote as a replacement, to avoid code duplication fails for me.

%!     assert (isdiag (d))
%!     assert (isdiag (d2))
%!     assert (columns (d), 1)
%!     assert (columns (d2), 1)

(I replaced the assert (columns (d), 1) to assert (isvector(d), true) in a
later commit[2] (forget to mention it in commit message) but that isn't the
issue here)

In this part the test wants the d and d2 to be both diagonal matrix and a
column vector at the same time, which is not what we want. We want the d and
d2 to be diagonal matrix if the "matrix" flag is on and to be vector if the
"vector" flag is on.

Currently my repository is up to date, it contains all of my eig related work,
while the last patch I attached only miss the last commit.[3]

[1] http://hg.savannah.gnu.org/hgweb/octave/rev/59cadee1c74b
[2]
https://bitbucket.org/BarbaraLocsi/octave/commits/e4462c09aa92ed5529316d368474c617f7fb9d7a
[3]
https://bitbucket.org/BarbaraLocsi/octave/commits/83eb5fcafe160ce28d88b60c0805bccd9dafb531


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8960>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/