[Octave-patch-tracker] [patch #9077] image package: new function imfill.m

[Carnë Draug]

Follow-up Comment #16, patch #9077 (project octave):

The chanages from your previous commit are here
https://bitbucket.org/carandraug/octave-image/commits/916c51dc2838435aabbab2b55e2a5c7eca1d03cb?at=new-function-imfill-patch-9077


> It seems a bit of a "overkill" to me to assign warning ids to my imfill
warnings, only to silence them. I found another "workaround" way to achive
this: I just renamed the corresponding "!test" lines into "!warning" lines. If
you have "ethical" problems with this and prefer warning messages during the
tests, then just undo this change again.

The "%!warning" blocks are to test if a piece of code does throw an expected
warning.  I forgot that you don't actually need a warning id, you can simply
turn all warnings off for the test.

> Am an not sure about the advantages of the proposed different way of dealing
it. Do you want to be faster, or use less memory? I think both results would
not be significantly obtained by this. 

It uses less memory. As the number of dimensions go up, the size of padding
makes a big difference. It also involves a lot of copying internally which
makes things slower and require a lot more memory temporarily. I'm already not
happy that imreconstruct does more padding internally but in that case the
alternative I can think of is to check for coordinates at each pixel which
would be a performance killer.  Also, half of that more complex code will be
required to get the indexing for ND anyway.

Enjoy the vacations. This should be merged before the 3 weeks.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?9077>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/