[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-patch-tracker] [patch #9148] Added some BIST test for isinteger(

From: Mike Miller
Subject: [Octave-patch-tracker] [patch #9148] Added some BIST test for isinteger() in libinterp/corefcn/data.cc
Date: Tue, 1 Nov 2016 22:05:43 +0000 (UTC)
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:49.0) Gecko/20100101 Firefox/49.0

Follow-up Comment #5, patch #9148 (project octave):

Yes, it doesn't look like you changed the commit message from the last one
(file #38781). Please compare yours with this commit message for example:

You could use the single-line style as you have done, but you are missing the
asterisk character at the start of the line in that case.

You also still have some tests that are

%!assert (expression, false)

These should instead be written as

%!assert (! expression)

(Like I said, numerous examples of these kinds of tests throughout the Octave
code tree for you to refer to)


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]