[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-patch-tracker] [patch #9252] image package: hough.m (Matlab comp
[Octave-patch-tracker] [patch #9252] image package: hough.m (Matlab compatible wrapper around hough_line.cc)
Mon, 13 Feb 2017 14:27:32 -0500 (EST)
Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:51.0) Gecko/20100101 Firefox/51.0
Follow-up Comment #4, patch #9252 (project octave):
Thanks for reviewing my patch.
I have checked the Matlab behavior of hough.m. And yes, it really does convert
any BW input into a logical straight away. Any value that is not zero will be
counted as a one. Especially your new test (using the values [0.7 0.2 5])
passes fine in Matlab.
So I am fine with all your changes. I would be happy to see this pushed to the
forge image repository and be used in the next release of the image package.
Some notes that come to my mind (which I haven't seen in the bitbucket repo so
* We could now move hough_line to the private directory, or maybe only
deprecate it for now. (Maybe even deprecate houghtf.m along the way)
* In my original patch I also had a correction of the help text of
hough_line.cc, this would be useful to keep. (It might even be applied to the
stable branch already, it's a correction of the documentation.)
Reply to this item at:
Message sent via/by Savannah