[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-patch-tracker] [patch #9252] image package: hough.m (Matlab comp

From: Carnë Draug
Subject: [Octave-patch-tracker] [patch #9252] image package: hough.m (Matlab compatible wrapper around hough_line.cc)
Date: Fri, 17 Feb 2017 19:41:47 -0500 (EST)
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Firefox/45.0

Follow-up Comment #5, patch #9252 (project octave):

I have pushed your patch. I made two more changes:

1. added an otherwise on the switch block to catch any unknown property
2. made the function error if the user tries to set RhoResolution to anything
other than 1.  If a function can't do what the user wants, I think the best
coure of action is error and inform the user about it instead of doing
something else.

This will be part the next minor release (default branch):


> We could now move hough_line to the private directory, or maybe only
deprecate it for now. (Maybe even deprecate houghtf.m along the way) 

 hough_line is a an oct file so it can't be moved to private/ (oct files need
to be in the architecture dependent directory).  And it can't be deprecated
either because hough now makes use of it, meaning that calling hough would
trigger a deprecated warning.  You would have to rename hough_line to
__hough__ (the double underscores mark it as private for the users), have
hough call this new __hough__, make a new hough_line function that just calls
__hough__, and then deprecate hough_line.

> In my original patch I also had a correction of the help text of
hough_line.cc, this would be useful to keep. (It might even be applied to the
stable branch already, it's a correction of the documentation.)

You are right, this could have been committed to the stable branch but I got
distracted and pushed to the default branch instead.  If there is a patch
release, I will graft it into stable.



Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]