octave-patch-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-patch-tracker] [patch #9354] image package: new function wiener2


From: Hartmut
Subject: [Octave-patch-tracker] [patch #9354] image package: new function wiener2.m
Date: Thu, 25 May 2017 04:56:45 -0400 (EDT)
User-agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:53.0) Gecko/20100101 Firefox/53.0

Follow-up Comment #3, patch #9354 (project octave):

Thanks for reviewing, Avinoam.

I've done some changes to the file:
* missing space: done
* word "equation": done
* include book reference into help string: I haven't done this, yet. It feels
like inflating the user documentation too much. But I will leave this decision
to Carne.
* incompatibility with incorrect input nhood=[-5 0]: Not done. The resulting
error message is due to mean2.m being called with an empty matrix as input. I
will try to nail down this small incompatibility (in a possibly different bug
report), but I think there shouldn't be a workaround in wiener2.m.

See the resulting (additional) changeset here:
https://bitbucket.org/hgimpel/octave-image/commits/b4e31442fb5d9ff24bc72878776c87026dde93e4

PS: I've just realised (due to Bitbuckets Octave syntax highlighting) that I
should change my code to always use double quotes for strings. See here:
https://bitbucket.org/hgimpel/octave-image/commits/c78b75bc3861dc69ce00a2775bfaed88b6138159?at=new-wiener2


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?9354>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]