[Octave-patch-tracker] [patch #9354] image package: new function wiener2.m

[Hartmut]

Follow-up Comment #16, patch #9354 (project octave):

Here is the underlying reason why the new tests for Nd images failed for me
(see comment #11 and comment #14): I used the fspecial.m file from the latest
(2.6.1) image release. This still canNOT deal with 3d neighborhoods:


>> pkg list
Package Name  | Version | Installation directory
--------------+---------+-----------------------
       image *|   2.6.1 | /home/hartmut/octave/image-2.6.1

>> fspecial ("average", [3 3 3])
ans =

   0.11111   0.11111   0.11111
   0.11111   0.11111   0.11111
   0.11111   0.11111   0.11111


When I switch to the latest version of fspecial.m (in the official image repo)
then all the test of wiener2.m now do PASS on my machine as well. No need to
change those new tests. So I was only misled by the commit message on the
change of fspecial.m. This change was not only about performance, it also make
Nd neighborhoods for the average filter possible.

Conclusion: Are the maybe many more places in fspecial.m, that currently do
not support the creation of Nd filter matrices (and silently return a 2d
matrix)?

(I'll probably come up with new tests for wiener2 with even sized
neighborhoods, tomorrow.)

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?9354>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/