octave-patch-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-patch-tracker] [patch #9407] image package: new function houghpe


From: Avinoam Kalma
Subject: [Octave-patch-tracker] [patch #9407] image package: new function houghpeaks.m
Date: Mon, 31 Jul 2017 00:43:25 -0400 (EDT)
User-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.115 Safari/537.36

Follow-up Comment #3, patch #9407 (project octave):

Sorry for my late response:

I have checked houghpeaks on Windows 7. A few points:

1. Testing:


>> test houghpeaks
PASSES 32 out of 32 tests


2. Nice demo :-)

3. Coding style: I have two questions:

  if isempty (threshold)
or
  if (isempty (threshold))

  !isimage (H)
or
  ! isimage (H)

4. Matlab Compatibility:


I = max(0, phantom ());
H = hough(I);
P = houghpeaks(H,5)


Octave
P =

   586   136
   594   136
   311    46
   523   104
   374    46

Matlab

P =

   585   136
   310    46
   595   136
   522   104
   373    46

The order is different, and there a shift of one pixel in Y.
The problem is probably from hough, and not from houghpeaks.

Thanks!





    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?9407>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]