octave-patch-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-patch-tracker] [patch #9440] Add Flatpak build manifest


From: Alexander Wilms
Subject: [Octave-patch-tracker] [patch #9440] Add Flatpak build manifest
Date: Sun, 20 Aug 2017 12:12:08 -0400 (EDT)
User-agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.101 Safari/537.36

Follow-up Comment #3, patch #9440 (project octave):

* Does the directory have to be called "flatpak"?
** No, the .json manifest and the patches can be placed anywhere
* Why do you have to remove "<project_group>GNU</project_group>"? I know this
has come up before but I still don't understand it.
** I removed the project_group tag, since appstream used to only support a
whitelist, which didn't include the value "GNU". This has since been fixed:
https://github.com/hughsie/appstream-glib/issues/168 , so I can remove that
patch
* Can't EPSTOOL_BASE be passed on the make command line instead of patching?
** I'll have to take another look at that.
* Isn't there a way to call qmake or make on qscintilla to avoid patching?
** I'll have to take another look at that.
* Why does the huge block of pcre tests have to be removed from configure? If
the tests are failing can we fix that a different way?
** The configure step failed with "gcc: error: unrecognized command line
option '--should-not-have-used-/usr/bin/pcre-config'" Alexander Larsson, the
main Flatpak dev said "Means it tried to use pcre-config to find pcre, but
yocto kinda neuters all this. So you need to use pkg-config instead.
Alternatively, I believe you can pass some --with-pcre=... kinds of flags to
avoid the autodetection."
This
https://github.com/01org/luv-yocto/blob/master/meta/recipes-devtools/swig/swig/0001-configure-use-pkg-config-for-pcre-detection.patch#L7
looks like that this issue might be fixed in a future version of PCRE
* Should we name our desktop and appdata files to be "org.octave.Octave"
instead of "www.octave.org-octave"?
** Yes, and ideally, the desktop, appdata and icon files should all use the
same ID.
* I think the name of the application should be "org.octave.Octave"
** I'll change this
* I don't think the LIBGL_ALWAYS_SOFTWARE=1 environment variable is
appropriate to set unconditionally. Some users might need it depending on
their *  graphics hardware but it should not be necessary for everyone.
** I'll fix this. I've only run it in a VM so far, so that might be the reason
why I needed that env variable. I would be helpful if someone could test it on
a real machine
* OpenBLAS should be built with DYNAMIC_ARCH=1, not TARGET=PRESCOTT
** I'll fix this
* Why are you downloading epstool from fedoraproject.org?
** The official server is down:
http://pages.cs.wisc.edu/~ghost/gsview/epstool.htm
* Do you have an example build log that you can share with us to show what the
configure results look like?
** I'm building it right now, I can upload the log later

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?9440>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]