[Octave-patch-tracker] [patch #9494] Patches for polygon2patch & joinPolygns

[Juan Pablo Carbajal]

Follow-up Comment #1, patch #9494 (project octave):

I started working with the cset for joinPolygons. 

I found the some problems, so I did the following and pushed these changes
(hopefully they implemente the desired functionality).

- The cset changes the whole file when actually only 2 lines changed

- I do not find the parent revision nor the node ID in the log of the
repository

- With the new input checking a previous test fails (I fixed the input
checking, please check):

assert (joinPolygons ({1,2}), [1 2]);


- The function works with the following input, but I do nto what the output
means- Maybe this input shouldn't be accepted

joinPolygons ({[0 1;1 0],[0 1;2 0]})
ans =

   0   1   0   1
   1   0   2   0


Maybe the input should be rejected on the basis that the cell array is not
vertical. This would be in accordance with the help text.

The changes I made are in 2be7484d72c9
https://sourceforge.net/p/octave/geometry/ci/2be7484d72c9cf0c021c16a5a9852e23678792dd/tree/



    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?9494>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/