[Octave-patch-tracker] [patch #9449] image package: new function viscircles.m

[Carnë Draug]

Update of patch #9449 (project octave):

                  Status:                    None => Done                   
             Open/Closed:                    Open => Closed                 

    _______________________________________________________

Follow-up Comment #6:

The implementation has three issues:

* the input checking of param-value pairs should be done with inputParser to
simplify code.
* it loops over each circle to draw which should be vectorized away
* if the figure was on "hold" before the function, it will change its state
(should use unwind_protect and restore the initial state)
* returns an empty hg group instead of a group of the circles

I had an unfinished implementation of viscircles from 2015

https://bitbucket.org/carandraug/octave-image/commits/4e7cdf90c76ea3046432c529ee8e2a69781390b2

At the time, there was no option Color and EnhancedVisibility, there was
EdgeColor and DrawBackgroundCircle. It seems like Matlab just maps the old
property names to the new ones so I did the same. This makes the input
checking a bit messier but a lot of the existing code snippets make use of the
old names so I think we should keep them.

I amended my previous code with those changes and pushed it to the default
branch:

http://hg.code.sf.net/p/octave/image/rev/5a0b96c36f41

and added the demo and tests from this patch

http://hg.code.sf.net/p/octave/image/rev/aa5a1ca19146

The returned hg group is different from Matlab but I think the issue is how
line and plot works and not on the viscircles code. I'm not great at the whole
potting thing so maybe someone can comment where the issue is.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?9449>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/