[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-patch-tracker] [patch #9606] [Octave-forge] (image) New function

From: Hartmut
Subject: [Octave-patch-tracker] [patch #9606] [Octave-forge] (image) New function integralImage
Date: Sun, 25 Mar 2018 10:55:54 -0400 (EDT)
User-agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:59.0) Gecko/20100101 Firefox/59.0

Follow-up Comment #1, patch #9606 (project octave):

Thanks for creating this new function, Avinoam.

I've had a quick glance over it. Some comments:
* In the doc string: You could mention the 45 degrees value to clarify the
"rotated" option.
* The "upright" code version uses cumsum, but the "rotated" code path uses two
nested for-loops. Could this somehow be vectorized (as already mentioned in
the code comments) for speed?
* The tests all pass. But I haven't checked if they are Matlab compatible.
* I think the coding styles requires double quotes for strings.


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]