[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-patch-tracker] [patch #9587] [octave forge] (signal) db2pow: new

From: Mike Miller
Subject: [Octave-patch-tracker] [patch #9587] [octave forge] (signal) db2pow: new function
Date: Sat, 31 Mar 2018 01:54:55 -0400 (EDT)
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101 Firefox/59.0

Update of patch #9587 (project octave):

                  Status:                    None => In Progress            


Follow-up Comment #4:

Can you please combine the series of patches you have posted here into a
single patch? You can do this using hg histedit or hg fold, or other non-hg
patch management tools.

Please remove the %!demo block at the end, it isn't offering much that the
%!tests don't already show (a user can run "test db2pow verbose" to see the
test specifics).

Please indent line 40 with the rest of the function body. And please use
spaces around all binary arithmetic operators, like you did in pow2db.m.

Have you tried the doctest function yet? Can you install doctest (pkg install
-forge doctest) and run "doctest db2pow" and see if you can rewrite the doc
string example to pass?

And lastly, can you keep your name in mixed case on the Copyright line, just
as you have it in the hg commit log, don't include your email address in the
Copyright line, and can you use the most recent revision of the GPL license
header block? You can find it in any of the other .m files in Octave or in the
signal package.

I realize and admit that these are a lot of nitpicky things, but these are
things that I would have to be going through and fixing on my own if you don't
help me with them, so it would be helpful and good practice if you wouldn't
mind helping me take care of them.


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]