[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-patch-tracker] [patch #8575] [octave forge] (signal) lpc: new fu
[Octave-patch-tracker] [patch #8575] [octave forge] (signal) lpc: new function
Wed, 4 Apr 2018 02:03:19 -0400 (EDT)
Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101 Firefox/59.0
Update of patch #8575 (project octave):
Status: None => Need Info
Follow-up Comment #2:
Thank you for your work on this lpc function file. I'm sorry it has taken so
long for me to get around to looking at this submission.
The lpc function is definitely needed in the signal package, and your function
seems basically functionally correct to me. There are some Matlab
compatibility issues remaining, and some additional error checking that could
be added to ensure x and p are correct. For example, Matlab lpc can be called
with one argument, and p defaults to length(x)-1. The function should also
verify that x is real. The value p can be equal to length(x). And the
prediction error second return value should be a scalar, not a vector result.
This is definitely a good candidate function for including a demo that will be
shown in the online manual. For example a demo that creates an autoregressive
process and shows the original signal against the estimate, similar to what is
shown on Matlab's help page.
And beyond that there are some small Octave coding style changes to make (use
spaces before parentheses, but not when indexing; use '!' instead of '~'; use
the name of the variable uppercased instead of 'arg 1' in error messages).
Again, sorry for the delay, but let me know if you are interested and
motivated to work on this a bit more and submit another revision.
Reply to this item at:
Message sent via/by Savannah
- [Octave-patch-tracker] [patch #8575] [octave forge] (signal) lpc: new function,
Mike Miller <=