octave-patch-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-patch-tracker] [patch #9587] [octave forge] (signal) db2pow: new


From: Mike Miller
Subject: [Octave-patch-tracker] [patch #9587] [octave forge] (signal) db2pow: new function
Date: Tue, 10 Apr 2018 12:13:03 -0400 (EDT)
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101 Firefox/59.0

Follow-up Comment #6, patch #9587 (project octave):

I am posting comments here for both db2pow and pow2db.

In your latest patches you are still missing some important whitespace.
Specifically:

* write "10 .^ (db/10)" instead of "10.^(db/10)", as I mentioned in comment
#4
* write "db2pow (x)", "pow2db (x)", and "error (x)" instead of "db2pow(x)",
"pow2db(x)", and "error(x)"

The doc strings could use some spell checking and are missing some
punctuation.

No need to make yet another revision, I will take these patches, clean them up
as mentioned above and add them to the signal package.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?9587>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]