[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-patch-tracker] [patch #9365] image package: new function deconvw

From: Carnë Draug
Subject: [Octave-patch-tracker] [patch #9365] image package: new function deconvwnr.m
Date: Wed, 19 Dec 2018 22:28:13 -0500 (EST)
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0

Update of patch #9365 (project octave):

                  Status:             In Progress => Done                   
             Open/Closed:                    Open => Closed                 


Follow-up Comment #11:

I have pushed this patch with mainly style changes. Thank you for the patch
and I'm sorry for the long wait.

The values of PSF and K may come from any other computation and may be of
class single not because of the memory usage of that scalar value but because
the values used to computed them were single to start with.  Just like we
simply convert img to double, we could do the same for others instead of
forcing the user to do it explicitly. Also, on the case of float images being
usually between the range [0 1], while that is what the language suggests, I
find that users rarely do it.  Anyway, it was just a a minor suggestion.

I pushed the patch after some minor fixes on the input checking.  I used isa
instead of comparing class names, adjusted whitespace, deleted a lot of
trailing whitespace, removed obvious comments, used variable names that are
common in other functions (such as using cls instead of class_before), and
moved the lines that actual perform the deconvolution to a separate

The only change of actual code I made was the check for the psf dimensions.
You were comparing only against one of the dimensions of the image which made
the test fail in a case such as: 

deconvwnr (ones (5, 8, 2), ones (6, 5))

I have also checked the error string for the input check tests otherwise
they're not very helpful. In most of those cases, even if the input checking
fails the function does fail. What the test needs to check is whether the
function catches those early enough and gives a useful message instead of
something much later and much cryptic for the user.


Reply to this item at:


  Message sent via Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]