[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-patch-tracker] [patch #9859] missing functions: stream2, stream3

From: Markus Mützel
Subject: [Octave-patch-tracker] [patch #9859] missing functions: stream2, stream3, streamline
Date: Sat, 30 Nov 2019 13:21:39 -0500 (EST)
User-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:71.0) Gecko/20100101 Firefox/71.0

Update of patch #9859 (project octave):

                  Status:                    None => In Progress            


Follow-up Comment #4:

Thanks again for your high quality contribution.

I went through your patch a bit more thoroughly and only made a few minor
changes. E.g:
* "!" instead of "~" for negations
* "endif", endfor", ... instead of "end"
* double quotes instead of single quotes
* transpose operator ".'" instead of Hermitian transpose "'"
* Matrix::extract instead of your function "crop_buffer".
* commit message more to standard.

Additionally, I moved the function back to "corefcn". I previously
misunderstood. Please accept my apologies for the additional work that my
previous comment has caused.

I'd like to push your contribution. But I don't know the stance on nick names
for copyright holders...
Would you mind having you clear name at the copyright?
Alternatively, it might be possible that you transferred your copyright to one
of the maintainers. Maybe jwe would accept?

Would you like to be added to the list of acknowledged contributors at the
beginning of the manual?

Could you please shed some light on why you use the following construct at the
end of the demos in streamtube.m?

%! props = {"cameraviewangle", "dataaspectratio", "plotboxaspectratio"};
%! set (hax, props, get (hax, props));

In "demo stream3", I can see what looks like white lines that partly cover the
attractor (more prominent if I rotate the view). Is this intended, or some
glitch (on my side?)?

(file #47953, file #47954, file #47955)

Additional Item Attachment:

File name: demo_stream3_1.png             Size:100 KB

File name: demo_stream3_2.png             Size:130 KB

File name: patch_streamline-20191123_v2.patch Size:45 KB


Reply to this item at:


  Message sent via Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]