[Octave-patch-tracker] [patch #8919] Start of patch to enable visibility attributes for GCC in build system

[Markus Mützel]

Follow-up Comment #17, patch #8919 (project octave):

After reading up on this a little more, I changed my mind about using only one
single macro for all libraries we build for Octave.
I'm no longer sure it is good practice to export the same symbols from
multiple libraries.

I tried to reproduce what jwe has done with his patches while maintaining the
different macros for the library APIs. "part2" is basically equivalent to
jwe's "patch-1" (but I split a part that isn't directly related to visibility
into "part1" and added a few more API flags).
"part3" is an alternative approach to jwe's "patch-2".
With these patches, I can compile without errors on Linux.

But I'm struggling when it comes to doing something equivalent for Windows.
More in a follow-up comment.

[1]:
https://docs.microsoft.com/en-us/troubleshoot/cpp/c2491-define-data-member-dllimport

(file #50569, file #50570, file #50571)
    _______________________________________________________

Additional Item Attachment:

File name: patch8919_part1_libgui_graphics_map.patch Size:2 KB
   
<https://file.savannah.gnu.org/file/patch8919_part1_libgui_graphics_map.patch?file_id=50569>

File name: patch8919_part2_mark_API.patch Size:144 KB
   
<https://file.savannah.gnu.org/file/patch8919_part2_mark_API.patch?file_id=50570>

File name: patch8919_part3_visibility_Linux.patch Size:3 KB
   
<https://file.savannah.gnu.org/file/patch8919_part3_visibility_Linux.patch?file_id=50571>



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/patch/?8919>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/