[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-patch-tracker] [patch #10060] [octave forge] (statistics) Update

From: Nicholas Jankowski
Subject: [Octave-patch-tracker] [patch #10060] [octave forge] (statistics) Update function confusionchart
Date: Sun, 28 Nov 2021 14:38:48 -0500 (EST)
User-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0

Update of patch #10060 (project octave):

                  Status:                    Done => Ready For Test         
             Open/Closed:                  Closed => Open                   


Follow-up Comment #3:

@philip: I've attached two patches here to address the 'test confusion'
figures issue.  It's solved by using a test block instead of 1-liner tests,
and temporarily setting visibility to 'off' inside the block. 

One patch just runs them all inside a single test block, turning the setting
off and resetting it at the end.  This, however, only reports all pass/fails
as a single test, which is sometimes deemed undesirable as you can't tell
which test failed.

The second patch does the same thing, but instead breaks out each error test
as an individual test block.  That's probably better from a test perspective,
but maybe some people like the trimmer code.  

The difference between the two is essentially:

>> test confusionchart

PASSES 1 out of 1 test

>> test confusionchart
PASSES 18 out of 18 tests

feel free to apply whichever you prefer, either should apply clean to the
latest tip.

(file #52366, file #52367)

Additional Item Attachment:

File name: octave-statistics-confusionchart-suppresstestfigs_1test.patch
Size:3 KB

File name: octave-statistics-confusionchart-suppresstestfigs_manytests.patch
Size:6 KB


Reply to this item at:


  Message sent via Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]