[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-patch-tracker] [patch #10292] Switch from PCRE to PCRE2

From: John W. Eaton
Subject: [Octave-patch-tracker] [patch #10292] Switch from PCRE to PCRE2
Date: Thu, 10 Nov 2022 09:34:41 -0500 (EST)

Follow-up Comment #1, patch #10292 (project octave):

Thanks for providing these changes.

Octave's public header files should not depend on macros like
PCRE2_DATA_WIDTH, PCRE2_CODE_UNIT_WIDTH, or include the pcre2.h header
directly.  Using PCRE (or any library) is an implementation detail that
shouldn't be exposed to someone just wanting to use the regexp class.  That's
why we used the void pointer previously and only included the header files in
.cc files.

If we need a change for OCTAVE_CHECK_LIB, that should probably be discussed

How do we know that a buffer size of 128 is sufficient for the call to
pcre2_get_error_message?  Should we try to adapt that in case the message ends
up being longer and pcre2_get_error_message returns a failure code?


Reply to this item at:


Message sent via Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]