[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-patch-tracker] [patch #10288] Implementation of Matlab function

From: Kasper H. Filtenborg
Subject: [Octave-patch-tracker] [patch #10288] Implementation of Matlab function tensorprod
Date: Tue, 29 Nov 2022 18:06:38 -0500 (EST)

Follow-up Comment #18, patch #10288 (project octave):

Thank you for pointing out the changes that you made. They make a lot of
sense, and they will be good to have as a reference should I have another

I have looked through the file and have not spotted any problems. I have only
two really minor things:
 - Double space in line 53 (after the colon)
 - Shouldn't the use of single and double quotes be flipped in the error
messages where both are used so that e.g. '"all"' is used instead of "'all'"
to produce "all" in the printed error message? I think this is more consistent
with other printed information as e.g. "help tensorprod". (I see that some
functions are using 'foo' and others "foo" in error messages.)

And just for my understanding, how does the compiler know not to include the
changes from the patch? Shouldn't there be another branch for version 9?


Reply to this item at:


Message sent via Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]