[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Openexr-devel] Request for testing
From: |
Drew Hess |
Subject: |
Re: [Openexr-devel] Request for testing |
Date: |
Tue, 2 Dec 2003 17:54:44 -0800 (PST) |
Thank you once again for your Win32 contributions, Lutz! I'll go through
this and sync it up with CVS.
-dwh-
On Wed, 3 Dec 2003, Lutz Latta wrote:
> Hi Drew,
> I tested the current CVS code on Windows in Visual C++ 7.1.
>
> The IlmImfDll project was missing some files (ImfPreviewImage*,
> ImfConvert.*). I added those to the project.
>
>
> The IlmImfTest has some errors, most of them I could fix:
>
> - the testMagic() failed, because it tried to check that the file "Makefile"
> is no exr file. Due to automake stuff that file does not exist on Windows. I
> changed it to check "main.cpp" instead. I also changed the post-build step to
> immediately run the test program in the source/example image directory,
> without copying the files to the visual studio project path.
>
> - the testStandardAttributes() used a hard coded temp file path to the
> "/var/tmp" directory. I changed that with an #ifdef PLATFORM_WIN32 to the
> local directory.
>
> - the testNativeFormat() throws an exception deep down in the code (in
> ImfInputFile.cpp:290) while reading an image. I don't know enough about the
> code to fix that.
>
>
> I also cleaned up the project files, there were some minor conflicting
> settings that probably resulted from the automatic conversion of the VC6
> projects. Additional changes in the compile settings are:
>
> - some settings like incremental linking (now always on in debug builds) and
> precompiled header usage (now always off) were inconsistent across the
> projects.
>
> - enabled generating debug info for all builds, even release - as this is
> never harmful, and if people don't distribute the debug symbol files, there
> is no "security risk" in giving out unwanted information.
>
> - disabled warning 4290, which clutters the build output with the unuseful
> information that the C++ throws clause in function declarations is
> unimplemented in the compiler.
>
> - enabled the ISO C++ conforming for-loop variable scope.
>
>
> I only manually tested reading the example images, not writing something. It
> looks like everything is working now, except the native format test. I don't
> know how important that is for you to delay the release. If you have an idea
> what might be wrong there, I would be willing to check that in the debugger.
>
>
> I attached the changed project and two source files in the zip file here.
> It's only 30K so I assume that's still acceptable. If there were larger
> changes, is there another way to submit files like this?
>
>
> So, good luck with the release.
> Lutz
>
>
>
>
>
>
Re: [Openexr-devel] Request for testing,
Drew Hess <=