Re: [Openvortex-dev] make errors while compliling.

[J. Gordon Wolfe]

On Wed, 2003-07-23 at 11:03, Richard Brown wrote:
> Hello,
> 
> I'm running gentoo1.4r4, fully emerged and am trying to compile alsa for
> my Aureal Semiconductor Vortex 2 (rev 254)
> 
> I've downloaded the alsa folder from the cvs and run 
> 
> # ./configure --with-cards=au8830
> 
> this has finished with no errors, but when I run make eventually it
> outputs this
> 
> gcc -D__KERNEL__ -DMODULE=1 -I/root/alsa/include
> -I/lib/modules/2.4.20-gentoo-r5/build/include -O2
> -mpreferred-stack-boundary=2 -march=i686 -D__SMP__ -DCONFIG_SMP -DLINUX
> -Wall -Wstrict-prototypes -fomit-frame-pointer -Wno-trigraphs -O2
> -fno-strict-aliasing -fno-common -pipe -DALSA_BUILD
> -DKBUILD_BASENAME=au8830_pcm   -c -o au8830_pcm.o au8830_pcm.c
> In file included from au8830_pcm.c:2:
> au88x0_pcm.c: In function `snd_vortex_pcm_pointer':
> au88x0_pcm.c:231: incompatible type for argument 1 of `_raw_spin_lock'
> au88x0_pcm.c:237: incompatible type for argument 1 of `_raw_spin_unlock'
> make[2]: *** [au8830_pcm.o] Error 1
> make[2]: Leaving directory `/root/alsa/pci/au88x0'
> make[1]: *** [_modsubdir_au88x0] Error 2
> make[1]: Leaving directory `/root/alsa/pci'
> make: *** [compile] Error 1
> 
> If someone could tell me how to sort this out I would be very grateful.
> 
> Regards
> 
> Richard.

Well it looks to be breaking on the spin_lock() and spin_unlock() call. 
My Gentoo system (kernel 2.4.20-ck6, 2.6.0-test1) compiles just fine
through those, so I'm not sure what your deal is.  However, I've always
been suspicious of those calls.  It seems everywhere else I see a
spin_lock() its parameter is passed by reference, and those aren't (even
in the driver code in the alsa tutorial, which the driver looks to be
largely based on).  So maybe you want to try and apply the attached
patch?  It works fine for me here, but then so did the original driver.

-- 
J. Gordon Wolfe <address@hidden>

au88x0_pcm_spinlock.patch
Description: Text document