[Pan-users] Re: Anyone get pan compiling with gcc 4.3 yet?

[walt]

Daniel Rahn wrote:
> On Thursday 27 March 2008 14:16:01 Duncan wrote:
> > Finally got it compiling and a new version installed now.  Updated
> > the bug, now time to restart pan and see if it actually works. =8^)
>
> I still think the best option would be to replace any includes of glib/*
> with just glib.h. That will pull in all the necessary deps for all glib
> versions pan is meant to compile against. It will however bloat things
> a bit.

In this particular case I agree with your idea to include glib.h -- that's
what that header file is for and it would have prevented this particular
compile error.  I don't think it would bloat anything, though, because
it affects only the output of cpp ('c' pre-processor).  It has no effect
on the compile or link phase and therefore has no effect on the size of
the finished executable or the amount of library code loaded into RAM at
runtime.  The only cost of including unneeded header files is a few micro
seconds of extra compile time -- i.e. truly trivial.

> I guess I'll just come up with a patch that does exactly that and then
> run some test compiles to see the size impact on the binary.
>
> Using ifdefs is one not really maintainable and two will not work,
> because at the time you do the ifdefs you already need the include to
> be present.
>
> You would need to come up with some autoconf magic. Volunteers?
>
> -Daniel