[Pan-users] Re: [Pan 0.133-Windows] Drops server

[walt]

On Sun, 28 Sep 2008 20:00:47 +0000, Duncan wrote:

> So it looks to me like Charles was inserted blank lines to fix a bug of
> /no/ blank lines before or after the insertion point line, but those
> could be removed if the real bug, the differing behaviour if one selects
> to quote vs simply quoting the entire thing.  In both cases there's five
> blank lines total where there should be three (with the new content on
> the middle one leaving one before and one after), but insertion point
> changes from OK at the top to OK at the bottom, depending on select to
> quote or not.  That would seem to me to be the real bug.

Okay, I found a few more spots where extra newlines were inserted, and
this patch removes them.  Give it a try with and without selecting and
see what you think.  Do you want *no* blank line above the sig?

--- pan/gui/post-ui.cc  (revision 363)
+++ pan/gui/post-ui.cc  (working copy)
@@ -1356,7 +1356,7 @@
     load_signature (profile.signature_file, profile.sig_type, sig);
     int ignored;
     if (GNKSA::find_signature_delimiter (sig, ignored) == GNKSA::SIG_NONE)
-      sig = std::string("\n\n-- \n") + sig;
+      sig = std::string("\n-- \n") + sig;
   }
   _current_signature = sig;
 
@@ -1367,15 +1367,15 @@
     insert_pos = 0;
   } else if (body.empty()) {
     insert_pos = 0;
-    body = "\n\n";
+    // body = \n";
     body += sig;
   } else if (sig.empty()) {
-    body += "\n\n";
+    body += "\n";
     insert_pos = body.size();
   } else {
     body += "\n\n";
     insert_pos = body.size();
-    body += "\n\n";
+    body += "\n";
     body += sig;
   }

-- 
Visualize clever sig here