Re: [Pan-users] [judgefudge tree] My eyes, they bleed, my stomach, it doesn't feel so well! (Colors screwed up.)

[Duncan]

Duncan posted on Wed, 26 Oct 2011 08:43:31 +0000 as excerpted:

> commit d2a0345a62449aa8d656e1bed531c5b119d20f69
> Author: Heinrich Müller <address@hidden>
> Date:   Sun Oct 23 03:30:47 2011 +0200
> 
>     fixed stupid ssl multithread pthread bug
> 
> Part of which is:

> @@ -298,7 +299,9 @@ HeaderPane :: render_subject (GtkTreeViewColumn * ,
>    g_object_set (renderer,
>      "text", text,
>      "weight", (bold ? PANGO_WEIGHT_BOLD : PANGO_WEIGHT_NORMAL),
> -    "underline", (underlined ? PANGO_UNDERLINE_SINGLE : 
> PANGO_UNDERLINE_NONE),
> +    "foreground",  unread ? p.get_color_str 
> ("score-color-read-fg",TANGO_ORANGE).c_str() :
> +                   "black",
> +    "background", unread ? p.get_color_str 
> ("score-color-read-bg","white").c_str() : "white",
>      NULL);
>  }

> What's *NOT* so fine, however, is the fallbacks if that
> unread-childposts condition does NOT hold.
> 
> Unfortunately, it hard-codes those, to something not only WAY
> different than my normal color-scheme, but something that can
> make me feel, literally, mildly nauseous, sick!

OK, this adds the needed extra set of prefs and seems to work fine, here.
(Plus, I just learned how to use git diff instead of doing the diffs
manually, as I've been doing to create patches to now, even when working
with git trees. =:^)

diff --git a/pan/gui/header-pane.cc b/pan/gui/header-pane.cc
index 47df21c..248e8d8 100644
--- a/pan/gui/header-pane.cc
+++ b/pan/gui/header-pane.cc
@@ -299,9 +299,10 @@ HeaderPane :: render_subject (GtkTreeViewColumn * ,
   g_object_set (renderer,
     "text", text,
     "weight", (bold ? PANGO_WEIGHT_BOLD : PANGO_WEIGHT_NORMAL),
-    "foreground",  unread ? p.get_color_str 
("score-color-read-fg",TANGO_ORANGE).c_str() :
-                   "black",
-    "background", unread ? p.get_color_str 
("score-color-read-bg","white").c_str() : "white",
+    "foreground",  unread ? p.get_color_str 
("score-color-unread-fg",TANGO_ORANGE).c_str() :
+                   p.get_color_str ("score-color-read-fg","black").c_str(),
+    "background", unread ? p.get_color_str 
("score-color-unread-bg","white").c_str() :
+                   p.get_color_str ("score-color-read-bg","white").c_str(),
     NULL);
 }
 
diff --git a/pan/gui/prefs-ui.cc b/pan/gui/prefs-ui.cc
index c1b142d..1659190 100644
--- a/pan/gui/prefs-ui.cc
+++ b/pan/gui/prefs-ui.cc
@@ -637,7 +637,7 @@ PrefsDialog :: PrefsDialog (Prefs& prefs, GtkWindow* 
parent):
   row = 0;
   t = HIG :: workarea_create ();
   HIG :: workarea_add_section_title (t, &row, _("Header Pane"));
-    HIG :: workarea_add_section_spacer(t, row, 6);
+    HIG :: workarea_add_section_spacer(t, row, 7);
     h = gtk_hbox_new (false, PAD);
     pan_box_pack_start_defaults (GTK_BOX(h), gtk_label_new (_("Text:")));
     pan_box_pack_start_defaults (GTK_BOX(h), new_color_button 
("score-color-watched-fg", "black", prefs));
@@ -670,10 +670,16 @@ PrefsDialog :: PrefsDialog (Prefs& prefs, GtkWindow* 
parent):
     HIG :: workarea_add_row (t, &row, _("Scores of -9999 or less:"), h);
     h = gtk_hbox_new (false, PAD);
     pan_box_pack_start_defaults (GTK_BOX(h), gtk_label_new (_("Text:")));
-    pan_box_pack_start_defaults (GTK_BOX(h), new_color_button 
("score-color-read-fg", TANGO_ORANGE, prefs));
+    pan_box_pack_start_defaults (GTK_BOX(h), new_color_button 
("score-color-read-fg", "black", prefs));
     pan_box_pack_start_defaults (GTK_BOX(h), gtk_label_new (_("Background:")));
     pan_box_pack_start_defaults (GTK_BOX(h), new_color_button 
("score-color-read-bg", "white", prefs));
     HIG :: workarea_add_row (t, &row, _("Read collapsed Thread:"), h);
+    h = gtk_hbox_new (false, PAD);
+    pan_box_pack_start_defaults (GTK_BOX(h), gtk_label_new (_("Text:")));
+    pan_box_pack_start_defaults (GTK_BOX(h), new_color_button 
("score-color-unread-fg", TANGO_ORANGE, prefs));
+    pan_box_pack_start_defaults (GTK_BOX(h), gtk_label_new (_("Background:")));
+    pan_box_pack_start_defaults (GTK_BOX(h), new_color_button 
("score-color-unread-bg", "white", prefs));
+    HIG :: workarea_add_row (t, &row, _("Unread collapsed Thread:"), h);
   HIG :: workarea_add_section_divider (t, &row);
   HIG :: workarea_add_section_title (t, &row, _("Body Pane"));
     HIG :: workarea_add_section_spacer (t, row, 3);


-- 
Duncan - List replies preferred.   No HTML msgs.
"Every nonfree program has a lord, a master --
and if you use the program, he is your master."  Richard Stallman