Re: [Pan-users] Bug 756458 pan 0.139 crashes on start

[Rhialto]

On Wed 06 Jan 2016 at 14:21:36 -0700, Zan Lynx wrote:
> On 01/06/2016 12:19 PM, Rhialto wrote:
> > So keeping every step of the way in the StringView realm is definitely
> > better. Whether the actual string storage is safe in the long term, I
> > didn't look at, but presumably it is or more things would go wrong
> > (probably).
> 
> Whereas I believe the opposite:

I just looked at this very specific small case.

> every StringView used in the preference
> code should be replaced with a simple std::string.

That is probably better indeed, but more work and not what I looked at :-)

-Olaf.
-- 
___ Olaf 'Rhialto' Seibert  -- The Doctor: No, 'eureka' is Greek for
\X/ rhialto/at/xs4all.nl    -- 'this bath is too hot.'

signature.asc
Description: PGP signature