Re: [Pan-users] 64-Bit Windows build

[Steve Davies]

On 25/04/2017 20:23, Petr Kovar wrote:
> > Yes, happens to me too (I had not noticed!) on Windows 10.
> >
> > I'll try and update everything I can and re-build. It is not a
> > fundamental date formatting issue because the article pane shows the
> > date just fine...
> Was just wondering, do you build Pan with GTK+ 2 or 3? I wouldn't be
> surprised if this was a problem in older versions of GTK+.
>
> pk
GTK+3 is not yet usable on Windows builds as far as I can tell, but I 
did find the issue - Not sure how to submit the following, so here is a 
"patch" for you to check and merge if you like it.

commit cfbf70be8e083b8a35fc94fad5d5c902c024a223
Author: Steve Davies <address@hidden>
Date:   Tue Apr 25 20:13:33 2017 +0100

    Fix the strftime test for mingw64

    mingw64's strftime returns an empty string when the %l and %h 
tokens are not understood.

diff --git a/configure.ac b/configure.ac
index 4caae04..cce6c24 100644
--- a/configure.ac
+++ b/configure.ac
@@ -240,13 +240,14 @@ dnl Check to see if strftime supports the use of 
%l and %k
 AC_MSG_CHECKING(for %l and %k support in strftime)
 AC_RUN_IFELSE([AC_LANG_SOURCE([[
 #include <string.h>
+#include <stdlib.h>
 #include <time.h>
 int main(int argc, char **argv) {
   char buf[10];
   time_t rawtime = time(0);
   struct tm *timeinfo = localtime (&rawtime);
   strftime(buf, 10, "%l %k", timeinfo);
-  exit (strstr(buf, "l") || strstr(buf, "k") || !strcmp(buf," "));
+  exit (strstr(buf, "l") || strstr(buf, "k") || !strcmp(buf," ") || 
!strlen(buf));
 }]])],[
 AC_DEFINE(HAVE_LKSTRFTIME, 1, [strftime supports use of l and k])
 ac_cv_lkstrftime=yes


The above will probably be destroyed in-transit :(
Steve