[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Paparazzi-devel] roll_trim

From: Felix Ruess
Subject: Re: [Paparazzi-devel] roll_trim
Date: Fri, 23 Aug 2013 09:01:20 +0200

Hi Refik,

There is a small spell error in main_ap.c and main_fbw.c:

   * these are passed to fbw via inter_mcu.
>>>>>>> origin/master

You got a conflict merging in master and didn't fully resolve it, this is the rest of that.
It's fine in paparazzi master.
I corrected it in my computer and checked the trim values. It takes the trim values from airframe file.

Great, thanks.

Cheers, Felix 


From: Felix Ruess
Subject: Re: [Paparazzi-devel] roll_trim
Date: Thu, 22 Aug 2013 14:49:41 +0200

Hi Refik,

Thanks for noticing and reporting this!
Seems the trim commands were not properly initialized.
The values set in the airframe file were directly written to command_x_trim in fbw, only to be overwritten later from the ap_state->command_x_trim values (which are not explicitly initialzed and hence zero). So when you change the trim commands in settings, only then they are actually applied.

Now the command_x_trim values are initialized in ap_state instead of fbw (and the yaw trim is also set from the airframe file, which was apparently missing before).

Should be fixed in v5.1_devel-148-ga18a74f

Please test and report back.

Thanks, Felix

Paparazzi-devel mailing list

reply via email to

[Prev in Thread] Current Thread [Next in Thread]