[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Patch-gnuradio] patch for gr_noise_source and previously submitted patc

From: Tim Meehan
Subject: [Patch-gnuradio] patch for gr_noise_source and previously submitted patch for gr_trellis
Date: Fri, 16 Mar 2007 08:42:36 -0400


Please see attached patch for gr_noise_source and qa code.  Also
included in this patch is previousle submitted patch for gr_trellis
and docs

Problem:  gr_noise_source returns the same sequence for all positive
seeds.  This is probably not the expected result and will likely lead
to confusion.

Reason: gr_noise_source calls function derived from well known ran1()
function that sets all positive value seeds to 1.

from gr_random.c gr_random::ran1()
 if (d_seed <= 0 || !d_iy)  {
   if (-d_seed < 1)

proposed fix:  Mod gr_noise_source to call gr_random with a negative
value if called with a positive seed.


Attachment: gr_trellis_and_gr_noise_source.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]