Re: [Patch-gnuradio] Typo in gr_peak_detector_XX.cc.t

[Johnathan Corgan]

On Fri, Apr 11, 2008 at 2:49 AM, Andreas Müller <address@hidden> wrote:

>  gr.peak_detector_fb sometimes detects the peaks at a later position than
>  they actually are.

>  -    return peak_ind+1;
>  +    return peak_ind;

The patch you submitted would undo an update Tom Rondeau made to the
file in r7587 this last February:

http://gnuradio.org/trac/changeset/7587#file2

This was actually a merge from his developer branch:

http://gnuradio.org/trac/changeset/7586#file0

The log message was:

"Had to revert to the old peak detector to get rid of the stall issue.
Still skipping some packets, but it's almost there. I think the peak
detector issue still needs some work and the answer lies somewhere
between this one and peak_detector2_fb."

So I'll let Tom comment on whether this should be applied or not.

-- 
Johnathan Corgan
Corgan Enterprises LLC
http://corganenterprises.com/