|
From: | Marek Mahut |
Subject: | Re: [Patch-gnuradio] Patch: build fix for gcc 3.4 |
Date: | Tue, 22 Apr 2008 11:51:36 +0200 |
User-agent: | Thunderbird 2.0.0.12 (X11/20080226) |
Eric Blossom wrote:
On Mon, Apr 21, 2008 at 11:31:10PM +0200, Marek Mahut wrote:Dear upstream, I don't have copyright assignment with the FSF yet. However this patch is a small, but I would like to request it for future contribution to FSF related projects. This patch fixes gnuradio 3.1.2 to be able to build under new gcc 3.4 [1]. In this newest gcc version many C/C++ compiler headers were cleaned from unnecessary includes, so applications who did not include ones they use explicitly failed to build, it's the case of gnuradio as well. We, in Fedora, are using attached patch to fix this problem. [1] http://gcc.gnu.org/gcc-3.4/ Have a nice day, Marek Mahut <address@hidden>: Patch to fix build under gcc 3.4Hi Marek, thanks!
Hello Eric,
I noticed that sometimes you used <string.h> and other times <cstring> and once or twice both of them. What's your rationale? Shouldn't either one of them work for all cases?
Oh, I forgot to change some strings from the old patch. Feel free to use <cstring> instead of <string.h> in C++ files.
Regards,
Eric
-- Marek Mahut https://fedoraproject.org/wiki/SIGs/Astronomy/ Fedora Project http://www.jamendo.com/
signature.asc
Description: OpenPGP digital signature
[Prev in Thread] | Current Thread | [Next in Thread] |