[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Patch-gnuradio] [PATCH] cmake: allow disabling of individual gr-aud

From: Tom Rondeau
Subject: Re: [Patch-gnuradio] [PATCH] cmake: allow disabling of individual gr-audio sound systems
Date: Sat, 16 Jun 2012 17:45:33 -0400

On Fri, Jun 15, 2012 at 9:27 AM, Chí-Thanh Christopher Nguyễn
<address@hidden> wrote:
> Hello,
> currently, gr-audio detects the available sound systems and enables all
> that it finds. This is undesirable on Gentoo as it causes so-called
> automagic dependencies.
> Attached patch adds new options to explicitly enable and disable the
> sound systems. The default behaviour remains unchanged.
> Best regards,
> Chí-Thanh Christopher

I'm a little iffy on this patch, mostly because it creates
gr-audio-xxx components that show up in the list of enabled/disable
components. I like the simplicity of only having gr-audio here; it
also makes it easier for newcomers to not panic that they have
disabled components.

I understand the idea, here, though, and agree that it could be nice
to have something like this. Is there a way to have a
-DDISABLE_GR_AUDIO_XXX concept that just registers a variable that can
then be tested during configuration? That way, you get the
command-line option to turn off a particular type of audio device
without actually making a new component.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]