[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Patch-gnuradio] GRC examples in gr-digital

From: Tom Rondeau
Subject: Re: [Patch-gnuradio] GRC examples in gr-digital
Date: Tue, 10 Jul 2012 10:14:08 -0400

On Mon, Jul 9, 2012 at 5:15 AM, Martin Braun (CEL) <address@hidden> wrote:
> On Sun, Jul 08, 2012 at 05:11:24PM -0400, Tom Rondeau wrote:
>> Hey Martin,
>> I've applied these patches locally. I'm working on a number of patches
>> that have been submitted all at once, so this should be pushed later
>> today.
>> I wish I had looked at this just a few hours ago. Johnathan and I are
>> working on some major updates on another branch where I also fixed
>> these, but in different ways. We'll just have to deal with the
>> conflicts when they come up now, though. Oh well.
> Sure :)
> Just to clarify: for the most examples, I simply changed them from 'not
> working' to 'working', and I don't care how that's done.
> However, for ber_simu.grc and pam_sync.grc, I actually think my
> solution is an improvement over the one in master (ber_simu.grc because of 
> Eb/N0,
> pam_sync.grc in my patch uses a scatterplot instead of scope plot for
> the post-sync signal and fixes some labels, so now you can see when your
> sync is working because you see a nice constellation diagram).
> MB


Sorry if that was confusing. I applied all of your patches for a
couple of reasons. First, yes, the BER patch and fixes to the DxPSK
mod/demod were definitely needed and useful. They were no-brainers.
The other fixes to the examples are also the right thing to do,
though. They fix the problems on both master and next. My fixes were
done on a branch that would only be applied to next. So it was just
easier to work with your fix. What we decided to do was to just ignore
my commit and merge in your work directly to our working branch. Makes
things cleaner and clearer that way.

I shouldn't have even brought it up; I was just kicking myself for
doing it on the branch before looking at your patches to see that they
would have fixed it for me. The way you did it was definitely the
right way.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]